Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better seed audit #69560

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Conversation

worm-girl
Copy link
Contributor

@worm-girl worm-girl commented Nov 19, 2023

Summary

Bugfixes "More seed fixes"

Purpose of change

#60885 hit right after I finished #65924 and pretty much caused me to throw my hands up and walk away from the project for a while, as it broke a lot of the work that had just been merged. Anoobindisguise tried to follow up on my work and fix some of the errors, but I didn't do a good job communicating at the time and gave them some bad advice.

Since then I've come back to working on the game and noticed a few issues popping up. I've tried getting them one by one but that wasn't really solving the underlying issue, pointed out by Anoobindisguise in #67432 - some of our seed piles are too big! I wanted to peg them all to the same size for various reasons including the seed paste/oil press stuff below, but at the end of the day it just doesn't reflect how people use the seeds IRL, and was probably causing more confusion than it prevented.

The main offenders here are pumpkin, sunflower, and cannabis seeds. I had initially pegged these at 1 "seeds" per plant. This later got swapped to 6 "seeds" for pumpkins and sunflowers, but the volume didn't change, which was causing the plants to wildly overproduce and was making some of our recipes really weird. Also if you wanted to eat sunflower seeds you had to commit to eating like 800 kcal of them.

Fixes #69549

Describe the solution

  • Audited seed craft and fruit/vegetable uncraft recipes to ensure that both give the same amount of seeds and (where applicable) fruit/vegetable pieces
  • Adjusted calorie values for seeds. They had previously been using unshelled, but our edible seeds still have the shells on. Shells occupy volume, so the calorie counts were off
  • Pumpkin seeds are now 1/6th of their former size. One pumpkin still produces 6 of them, totaling to 250ml of seeds, or a couple hundred. This is the original intended value and greatly reduces the caloric yield from pumpkins, which is how they work in real life. They are an endlessly useful food, but can't serve as a staple on their own
  • Sunflower seeds are now 1/4 of their former size. One wild sunflower produces 4 of them, totaling to 250ml of seeds. Homegrown sunflowers can produce more based on player skill
  • Cannabis seeds are now 1/6th of their former size. Cannabis is currently overproducing, as plants only give seeds when they're fertilized, and fertilized cannabis produces far less THC. We're still doing a lot of handwaving with botany as plants don't really have the mechanics needed for these kinds of things, so it's proooobably fine
  • Seed paste and oil press recipes were adjusted to maintain consistency between each other, and to correct for prior errors
  • One of the melon seed crafting recipes was short-changing the player on seeds

Describe alternatives you've considered

Closing my eyes and pretending I do not see the github issues.

Testing

  • Spawned in, grew one of each plant, harvested them, uncrafted a pumpkin and both kinds of melon
  • Crafted pumpkin seeds
  • Harvested wild and domestic sunflowers
  • Adjusted seed paste and oil press recipes to align with the new values. Noticed canola seeds (which are in a relatively huge pile and famously loaded with oil) required too many for paste. Fixed

Additional context

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Food / Vitamins Comestibles and drinks Crafting / Construction / Recipes Includes: Uncrafting / Disassembling <Bugfix> This is a fix for a bug (or closes open issue) labels Nov 19, 2023
@github-actions github-actions bot added the astyled astyled PR, label is assigned by github actions label Nov 19, 2023
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions labels Nov 19, 2023
@Maleclypse Maleclypse merged commit 011beab into CleverRaven:master Nov 22, 2023
19 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions <Bugfix> This is a fix for a bug (or closes open issue) Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Food / Vitamins Comestibles and drinks [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pumpkin seed inconsistencies
2 participants